On 30 novembre 10:32, Torsten Marek wrote: > Hi, Hi Torsten,
sorry for the late review, december has been a bit busy here... > I've updated the two existing patches (reimport / __all__ handling) and > added a tiny fix for the suppression warnings I0020/I0021. Please pull from > https://bitbucket.org/tmarek/pylint-patchqueue I've applied the two first from your patch queue. Regarding the two remaining: * the new check for non string object in __all__ is missing a test. Also, you may want to check for the type of the Constant node's value (ie __all__ = (1,)) * the other drop the message id if include-ids is not activated, which is imo undesired (as shown by the test update). Would you have some time to update them quickly ? If so, I'll wait for them until a new release of pylint (hopefuly soon). If not, I'll ever postpone them or try do find the time to do the changes myself (no guarantee unfortunatly). Thanks again for your contribution and happy new year! -- Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org _______________________________________________ Python-Projects mailing list Python-Projects@lists.logilab.org http://lists.logilab.org/mailman/listinfo/python-projects
