On 07 novembre 11:48, Torsten Marek wrote: > Hi, Hi Torsten,
I eventually found a couple of minutes to give a shot at your patches. > I've pushed a couple of patches to http://hg.diotavelli.net/ > > I've rebased the astroid patches that I've published before, they are now > at hg.diotavelli.net as well. I've integrated them beside the last one on the stack (after a couple of 2-spaces indentation fix). I feel like the last one deserves a little more work: IMO the SyntaxError information should come back to pylint, one way or another (though I agree probably not through the exception as this is error prone). Also, I dunno the catched cases but it seems incomplete as demonstrated with the example below generated while on this changeset: [syt@orion tmp]$ cat totu.py from toto import xxx xxx() [syt@orion tmp]$ pylint -rn totu.py ************* Module totu C: 1, 0: Missing module docstring (missing-docstring) F: 1, 0: Unable to import 'toto' (invalid syntax (<string>, line 1)) (import-error) Unhandled exception in VariablesChecker: invalid syntax (<string>, line 1) > The pylint patches are rather hefty, and I've included the support for > renaming warnings as we've discussed it a couple of months ago. > > The first free patches are relatively simple, the other four ones (1153 and > up) all depend on their predecessors. Whoah, there is great stuff in there. Beside the great step toward symbolic name handling (which makes pylint definitly easier to use and code easier to read), superfluous-paren is a nice one which will definitly hurts new comers to python ;) And the take on the spaces handling is definitly more powerful and flexible than the earlier implementation. Only one remarks: take care to not introduce two-spaces indent in pylint! Seriously, do you know any other company where coding standards says 2 spaces indent ! :p (hint: I know a tool which tells you about bad indentation) Now I should release, I'm sooo late on this :( Cheers, -- Sylvain Thénault, LOGILAB, Paris (01.45.32.03.12) - Toulouse (05.62.17.16.42) Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations Développement logiciel sur mesure: http://www.logilab.fr/services CubicWeb, the semantic web framework: http://www.cubicweb.org _______________________________________________ Python-Projects mailing list Python-Projects@lists.logilab.org http://lists.logilab.org/mailman/listinfo/python-projects
