Hi! On 04/06/2019 15:22, Denis Laxalde wrote: > This looks good to me overall; this contains many nice improvements !
Thanks for your review. > I pushed your patch in our review repository as a draft: > > https://hg.logilab.org/review/rql/rev/942ef0731f4c > > I just fixed weird characters in hg user and debian/changelog entry. > Perhaps something is wrong in the machine you're sending patches from? I'm going to double-check the locale configuration. Thanks for the advice. > In order to test this (I use an sbuild machine plugged into our CI), we > need an update of logilab-database's packaging and respective binary > packages built. Did you start working on it? If so, I'll build this > first, then check this patch back and possibly apply. Yes. The patches have been trapped by the moderation queue. I'll resend them to the cubicweb-devel mailing list if its a more suitable location. > Finally, we send all patches related to cubicweb ecosystem to > cubicweb-de...@lists.cubicweb.org (CCed) nowadays. The python-projects > mailing lists is kind of dead I think. >> +Vcs-Hg: https://hg.logilab.org/master/yams >> +Vcs-Browser: https://hg.logilab.org/master/yams > > Changed the lines above to rql. Oh dear. Nice catch! Copy/paste slopiness. -- Lunar _______________________________________________ Python-Projects mailing list Python-Projects@lists.logilab.org https://lists.logilab.org/mailman/listinfo/python-projects
