2014-01-25 Guido van Rossum <[email protected]>: >> - BaseEventLoop, BaseProactorEventLoop, BaseSelectorEventLoop > > What is the purpose of exporting these? (I don't really mind, but I > don't want to encourage people from subclassing these.)
Well, I don't know :-) Maybe if someone wants to implement its own event loop? But you don't want to encourage that, and it's still possible to import a submodule, so I remove these symbols from asyncio main module. >> - all queues symbols: Queue, Queue sublasses, Empty, Full > > I think that Empty and Full are too generic as names. Maybe we should > rename them to QueueEmpty and QueueFull? It didn't bother me when you > had to explicitly import the queue submodule. But now they are > exported by the package, I worry that someone doing "from asyncio > import *" (like many of the examples do) will find these names a bit > mysterious. I don't like having to care that asyncio is splitted into submodule, so I don't want to write "from asyncio.queues import Full". I prefer to rename Empty to QueueEmpty, and Full to QueueFull. -- Ok for not exporting other symbols. Victor
