2014-01-29 Anthony Baire <[email protected]>:
>> I just modified get_child_watcher() to add an optional loop parameter
>> in my subprocess_stream branch, so it's possible to run unit tests
>> with set_event_loop(None).
>>
>> http://code.google.com/p/tulip/source/detail?r=f9e077be6d3b97fde52b10131224d75696a0cbdf&name=subprocess_stream
>
> I think it may be confusing to expose this in the public API (intuitively
> one may think that get_child_watcher(loop) means get the watcher attached to
> the loop 'loop'). Is there a case where a user would need to tune this
> parameter ?

Well, there is no real use case, it was an hack to be able to write
unit tests. I reverted this change and I modified the unit tests to
use policy.set_child_watcher() instead.

Victor

Reply via email to