For the patch, honestly I'm not completely sure. If the patch doesn't break anything else, I'm okay, but I don't know what caveats there are. The example was nice, if that could ever work.
I got a copy of "The linux programming interface", still so much to learn :) Le jeudi 20 février 2014 11:14:36 UTC+1, Victor Stinner a écrit : > > 2014-02-20 8:57 GMT+01:00 Jonathan Slenders > <[email protected]<javascript:>>: > > > Thanks, the example is very clear and helpful! > > Sorry, but I didn't understand your opinion on the patch. Does it look > correct? It just found a new issue with the non-blocking mode when the > cat program is used as input. IMO the pipe should not be set to > non-blocking if it's a TTY. > > The worst case with my patch would be that the write protocol is not > notified immediatly when the PTY is closed or if the file descriptor > is closed, but only at the next write. > > Or would it be better to use a duplex pipe transport for PTY? > > Victor >
