After brief looking on code I have curious question: why do you use @coroutine even for non-blocking functions -- literally everywhere.
>From my perspective splitting the API to coroutines and functions-that-never-blocks is useful. At least you don't force user to write `yield from` for every call, which looks like a mess. Also splitting helps (now I say about myself) to create more clean API. On Mon, Mar 17, 2014 at 11:31 AM, Benoit C. <[email protected]> wrote: > Hello, > > I'm currently working on a lib that deals with amqp. > > The code is there: https://github.com/dzen/aioamqp/ > > I've been very inspired from : > > * Aymeric's websocket library ( https://github.com/aaugustin/websockets ) > * Barry Pederson ( http://barryp.org/software/py-amqplib/ ) for the > protocol parsing. > There is no release yet, and no tests for the moment. > > The library *works* but: > > * there is no authentication rather than the PLAIN one; > * there are currently no tests. > * it miss some informations for instance when creating a queue without name > (the server returns the name of the queue he created for you). > > I'll be glad to hear any review on this code. > > Benoît. -- Thanks, Andrew Svetlov
