2014-07-17 19:44 GMT+02:00 Guido van Rossum <[email protected]>: > I don't like mapping the exceptions; just document them.
Ok, agreed. > I do like always using a socket pair. And being able to send EOF reliably > sounds good! The patch is simple: http://codereview.appspot.com/115010043 "Subprocess: on UNIX, closing stdin now shutdowns writing the socket" There is just a drawback: transport.get_extra_info('subprocess').stdin is now a socket instead of a pipe on UNIX. The API is not the same: stdin.send() vs stdin.write(). IMO we can document this. Using directly the stdin object of subprocess.Popen is probably a good way to cause bugs in the transport. We might convert the socket to a file-like object in BaseSubprocessTransport._post_init() but it's not the best place for that. And as I wrote, I don't think that you should access directly Popen.stdin. Victor
