Looks perfectly reasonable to me!

Things I *like*:

   1. Your logic is kept separate from your GUI code; it makes me warm
   inside knowing that I could use the very same GUI, regardless of its
   complexity, for any number of my own logical needs, without having to think
   about the internal complexity.
   2. You call show from outside; you might consider it obvious, in which
   case that’s good, but I have both seen and been guilty of it myself of
   calling show from within __init__ which limits the use of the GUI and
   complicates reasoning when it comes time to hide it and potentially show or
   otherwise manage it’s liveliness later on.

Things I *don’t like*:

   1. Nothing! Except perhaps apart from a lack of super, e.g.
super(HierarchyDialog,
   self).__init__(parent) but it’s a detail.

Overall I’d say you’ve got it right so far!
​
​

-- 
You received this message because you are subscribed to the Google Groups 
"Python Programming for Autodesk Maya" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/python_inside_maya/CAFRtmOBUg_u0O6eeEFwzXFnVBzC5agP6Ncokp87Vz9e3Vu0H-w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to