Denis, The best way to submit patches is definitely to use the issue tracker.
I will create a wiki entry 'Contributor guidelines' and report to the list when it's done. Thomas 2010/5/25 Denis Barbier <bou...@gmail.com> > Replying to myself, I did not know that inserting [patch] in subject > would remove [Pythonocc-users]. Putting it back now, maybe some > people rely on this tag to filter messages and did not read the > original mail. > In order to avoid a dummy message, I will ask a question which is my > head for some days: are there guidelines for contributions? Like: > please use the issue tracker at googlecode, or sending patches to the > list is better? > > Denis > > On 2010/5/24 I wrote: > > Hello, > > > > As discussed here recently, the check about CSF_GraphicShr is causing > > trouble on Debian, and surely also on all other Linux distros. If I > > understand it right, this check had been added to catch Opencascade > > exceptions. > > Here is a patch to catch exceptions directly in swig code and convert > > them into Python exceptions. > > > > I did not want to recompile Opencascade on my box to remove the code > > to handle paths gracefully, so instead I set CSF_GraphicShr to a > > non-existing path to show what is printed: > > .../pythonocc/src$ CSF_GraphicShr=/path/to/nonexisting.dll python2.6 > > examples/Level1/HelloWorld/helloworld.py > > Display3d class initialization starting ... > > Traceback (most recent call last): > > File "examples/Level1/HelloWorld/helloworld.py", line 21, in <module> > > display, start_display, add_menu, add_function_to_menu = > init_display() > > File > "/home/barbier/.local/lib/python2.6/site-packages/OCC/Display/SimpleGui.py", > > line 161, in init_display > > win.canva.InitDriver() > > File > "/home/barbier/.local/lib/python2.6/site-packages/OCC/Display/qtDisplay.py", > > line 105, in InitDriver > > self._display.Create() > > File > "/home/barbier/.local/lib/python2.6/site-packages/OCC/Display/OCCViewer.py", > > line 74, in Create > > self.Init(self._window_handle) > > RuntimeError: /path/to/nonexisting.dll: cannot open shared object > > file: No such file or directory > > > > I am pretty sure that with an upstream installation, running this > > example without setting CSF_GraphicShr will throw an exception with > > this message: > > You have not defined CSF_GraphicShr or CASROOT, aborting... > > > > As shown above, this patch throws a RuntimeError exception, this can > > be easily modified if desired. > > > > Denis > > > > _______________________________________________ > Pythonocc-users mailing list > Pythonocc-users@gna.org > https://mail.gna.org/listinfo/pythonocc-users >
_______________________________________________ Pythonocc-users mailing list Pythonocc-users@gna.org https://mail.gna.org/listinfo/pythonocc-users
