Hi again, Thanks Rodolfo for your changes.
After retrieving them from his github repository, $ git branch master ticket_162_164 * ticket_81 $ I have seen following warning showing up in console when launching preferences window (Edit -> Preferences): (pytrainer:4997): libglade-WARNING **: unknown attribute `swapped' for <signal>. Functionality so far looks fine, but I think it would be a good idea to show expected units (based on system chosen) next to field names as now date format is shown next to date of birth (e.g. "Weight (kg):", "Height (cm):", etc.) to provide users a hint. From my point of view it is helpful not only in the window itself but also in error messages: "Error with the height field" -> "Height field must be in cm" (comments are welcome ;)) Another enhancement would be to somehow highlight text box which causes the error. I am not sure if it is better to make its frame red, change its background color or both. Regards, David 2012/1/27 David García Granda <dgra...@gmail.com>: > Hi Rodolfo, > >> please find attached the latest patch with the changes I mentioned earlier. >> I´ve also included some logging as David suggested. I´ve also upload the >> changes to a fork I created in github (rgonzalez72/pytrainer). > > Great, thanks! I would have a look at your fork and see how it works > with what Nathan proposes as I don't see any attachment in your email. > >> I had some trouble with the encoding on the glade tool so I changed the >> version and now I use glade3-3.7.3. This have made some weird changes in the >> glade xml file. Everything seems to work fine though. > > Glade is definitely evil! ;) > >> Please let me know if there´s any problem with the code. If you agree I >> might extend the changes to other fields. > > Sounds good. > >> I´m still looking at issue #81. >> >> My question are regarding the units of some input fields: >> >> In the profile, sports form, what are the units of MET (positive integer?) >> Extra weight (float >=0) and maximum pace (positive integer). > > MET: float >= 0 > Extra weight: float >= 0 > Maximum pace: float >= 0 > >> In the profile, equipment, what are the units of Life expectancy (positive >> integer?) and prior usage (integer >=0?). > > Life expectancy: integer > 0 > Prior usage: integer > 0 > > Hope it helps, > > David ------------------------------------------------------------------------------ Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 _______________________________________________ Pytrainer-devel mailing list Pytrainer-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pytrainer-devel
