hashar added a comment.
`pywikibot/i18n` has multiple directories. @jayvdb complaint about
banana-checker is you have to list each sub dir explicitly. Looking at
http://git.wikimedia.org/blob/pywikibot%2Fi18n.git/e7b1df619a27c80122d59892fbce7e12d24679da/Gruntfile.js
we have:
grunt.initConfig( {
banana: {
pywikibot: 'pywikibot/',
thirdparty: 'thirdparty/',
add_text: 'add_text/',
archivebot: 'archivebot/',
basic: 'basic/',
...
Which is error prone. Would be nice to have banana checker to support a glob
pattern of some sort so we can match all sub directories. Something like:
grunt.initConfig( {
banana: {
all: '*/',
}
@jayvdb you might want to fill a feature request on
https://github.com/wikimedia/grunt-banana-checker/issues
Another approach is to generate the banana configuration dynamically. Maybe the
Gruntfile.js can list the directories at the root of the repository and craft
the parameters for us.
TASK DETAIL
https://phabricator.wikimedia.org/T85335
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb, hashar
Cc: Krinkle, Jdforrester-WMF, Legoktm, Ricordisamoa, XZise, Xqt, siebrand,
Nemo_bis, jayvdb, hashar, valhallasw, Aklapper, Gryllida, Shizhao, Arrbee,
greg, pywikipedia-bugs
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
