XZise added a comment. All scripts in https://phabricator.wikimedia.org/tag/pywikibot-core/ now don't use `%s`. There is one patch remaining in the https://phabricator.wikimedia.org/tag/pywikibot-i18n/ repository to fix the remaining two which aren't in https://phabricator.wikimedia.org/tag/pywikibot-core/ and aren't used in https://phabricator.wikimedia.org/tag/pywikibot-compat/. I've added a note to the patches Gerrit 190710 <https://gerrit.wikimedia.org/r/190710> and Gerrit 203539 <https://gerrit.wikimedia.org/r/203539> that there is a patch changing it into a named parameter. So from the standpoint of the https://phabricator.wikimedia.org/tag/pywikibot-core/ and https://phabricator.wikimedia.org/tag/pywikibot-i18n/ repository all cases have been handled. I/We need to check https://phabricator.wikimedia.org/tag/pywikibot-compat/ though as that might use unnamed parameters still and will be broken as soon as the Python files are updated (they haven't been yet). Alternatively the converter from JSON to Python file could be modified to check for the keys and do something like `re.sub(r'%\([^)]*?\)s', '%s')`. I've also checked the i18n repository using `git grep -E "%[^.(s]" | grep en.json` and that does only show one translation where it's used for `strptime`.
TASK DETAIL https://phabricator.wikimedia.org/T98004 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise Cc: gerritbot, Ricordisamoa, XZise, pywikibot-bugs-list, Xqt, Aklapper, Malyacko, P.Copp _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
