XZise added a comment.
Okay I'll take a closer look tomorrow but there is a comment (the first line is
the line that failed):
hash_found = self.image.latest_file_info.sha1
if not hash_found:
return # Image deleted, no hash found. Skip the image.
So maybe it previously returned None instead of raising that exception. The
quick and easy fix would be to just catch that exception and handle it the same
way as None. But I want to check whether we introduced a regression somewhere
that it initially returned None instead of raising an exception. Additionally I
don't see why that should be None if the image exist so I want to check whether
the try-except could replace the current implementation there.
TASK DETAIL
https://phabricator.wikimedia.org/T105727
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise
Cc: XZise, Aklapper, Vituzzu, pywikibot-bugs-list, jayvdb, Malyacko, P.Copp
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
