jayvdb added a comment. In https://phabricator.wikimedia.org/T107335#1494337, @XZise wrote:
> One issue with a decorator could be if parameters are given positional, > because then you don't know which is the start and which is the end one. But > if you use a decorator which uses parameters (the suffix and exception class > for example) you could probably replace all usages. Ya, I am less concerned with whether it is a decorator, or not. My initial concern (sparked by the Flow patch: https://gerrit.wikimedia.org/r/#/c/217717/) was that it is hard to know whether these start/end range parameters are inclusive , or exclusive of the values provided. As noted, several methods dont have validation at all, and the docstrings for these params are missing or written in many different ways. Then I found 'rcdir' and 'rvdir', which are names I think we need to deprecate from the actual API before a releasing a long-term stable version of Pywikibot. TASK DETAIL https://phabricator.wikimedia.org/T107335 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: XZise, gerritbot, Aklapper, jayvdb, pywikibot-bugs-list, Malyacko, P.Copp _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
