XZise added a comment.

Okay I updated https://phabricator.wikimedia.org/P1881 to work more like 
pep8/flake8 as they are returning the error codes now in the order they appear 
in the message. It's not doing a SSH request if these two codes requiring it 
are ignored anyway. I added help text and a few other codes which check that 
the commit hash lengths are all equal and don't use mixed upper/lower case. I'd 
appreciate feedback about other repos than pywikibot whether the rules are also 
apply to their repos and if there are additional rules.

The code is not really perfect. At the moment M903 will be always replaced by 
M902 and M204 should check all commit hashes and not one… so if someone is 
using `1234aBcd` it should flagged as well as when `1234abcd` and `1234ABCD` is 
used within a message. Note that the codes > 900 are only warnings so (unless 
enabled) won't cause a failure.


TASK DETAIL
  https://phabricator.wikimedia.org/T109119

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: XZise
Cc: greg, Aklapper, pywikibot-bugs-list, XZise, jayvdb, hashar, Malyacko



_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to