XZise added a comment.
Okay after I compiled 3.5.0rc1 yesterday I ran it once and apart from
https://phabricator.wikimedia.org/T106209 I got three failures:
======================================================================
ERROR: test_add_claim_with_qualifier
(tests.wikibase_edit_tests.TestWikibaseWriteGeneral)
Test adding a claim with a qualifier to an item and a property.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/xzise/Programms/pywikibot/core/tests/wikibase_edit_tests.py",
line 83, in test_add_claim_with_qualifier
item.claims['P115'][0].addQualifier(end_date)
KeyError: 'P115'
======================================================================
ERROR: test_create_topic (tests.flow_edit_tests.TestFlowCreateTopic)
Test creation of topic.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/xzise/Programms/pywikibot/core/tests/flow_edit_tests.py", line
37, in test_create_topic
first_post = topic.replies()[0]
File "/home/xzise/Programms/pywikibot/core/pywikibot/flow.py", line 232, in
replies
return self.root.replies(format=format, force=force)
File "/home/xzise/Programms/pywikibot/core/pywikibot/flow.py", line 214, in
root
self._root = Post.fromJSON(self, self.uuid, self._data)
File "/home/xzise/Programms/pywikibot/core/pywikibot/flow.py", line 309, in
fromJSON
post = cls(page, post_uuid)
File "/home/xzise/Programms/pywikibot/core/pywikibot/flow.py", line 284, in
__init__
raise NoPage(page, 'Topic must exist: %s')
pywikibot.exceptions.NoPage: Topic must exist: [[test:Topic:Sn9e87gom98hr7sd]]
======================================================================
FAIL: test_label_remove (tests.wikibase_edit_tests.TestWikibaseWriteGeneral)
Test adding a Farsi and English label and removing the Farsi one.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/xzise/Programms/pywikibot/core/tests/wikibase_edit_tests.py",
line 56, in test_label_remove
self.assertNotIn('fa', item.labels.keys())
AssertionError: 'fa' unexpectedly found in dict_keys(['en', 'fa'])
All these look like race conditions as they edit something almost directly
before the test and then test that something. For example the last one was
pretty reproducible but as soon as I waited some time between the two requests
I couldn't get failures. I also experimented with it more and I got also a
failure sooner into that test where the addition of a label wasn't noticed.
Also after https://phabricator.wikimedia.org/T106212's problem with
dictionaries I checked the text returned by the API in the last failure and
that already did contain both entries. So it's not like the label dict screwed
up.
Not sure if Python 3.5 has made requests faster and so that it now doesn't give
the server enough time to update itself and the server is returning outdated
stuff.
TASK DETAIL
https://phabricator.wikimedia.org/T106224
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: XZise
Cc: gerritbot, Ricordisamoa, Aklapper, XZise, jayvdb, pywikibot-bugs-list,
Krenair, Malyacko
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
