abian lowered the priority of this task from "Unbreak Now!" to "Normal". abian added a comment.
In https://phabricator.wikimedia.org/T106412#1555560, @XZise wrote: > It's funny… when it's so easy go ahead and we help you to get it merged. > Anyway I looked through all `input` and `input_yn` calls: Thank you very much for taking this task on, XZise! Actually, completing it would be hard for us, who have no idea about Pywikibot, and easier for you, but it does require an effort in any case. I am fully aware of it, and I acknowledge it. > - The first is before it even starts when the source file name is invalid. I > guess `-always` will cause that to fail. Yes, I think this is what is expected. > - One is verifying the file name but `-keep` can already switch that off. > Should `-always` imply `-keep` then? I think so. > - When the file extension is invalid it asks you if you want to continue or > change the name. What should `-always` do? What does 'invalid' mean? - The source file extension does not match the content, but the destination file extension does → upload - The destination file extension does not match the content → not to upload (if implemented) - The destination file extension is not supported by the project → not to upload - The destination file name has no extension → not to upload > - When the file already exists it asks you if you want to continue or change > the name. What should `-always` do? In my opinion, this should be configured by another option (for example, `-ignorewarn`, or a new one, `-overwrite`). Without these possible options, `-always` should not upload. > - Additionally to the two above it may be that the file name is invalid (when > you upload not to commons but it already exists in commons). May not apply to > the project mentioned here but different from the two above `-always` will > skip these files because that cannot be fixed without changing the file name. Okay, I believe this is expected. > - There is a question whether the description should be changed. Now if I > understand the code correctly when the description is already defined > beforehand it won't ask you. But obviously without defining it, `-always' > won't be possible. Right. > - And the last one is a question when a warning happened. There is already > infrastructure to ignore it or abort it so `-always` could require it like > the description. Okay. Is there any case which has not been mentioned above? Thanks again. TASK DETAIL https://phabricator.wikimedia.org/T106412 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: XZise, abian Cc: -jem-, Mr.Ajedrez, XZise, Aklapper, abian, pywikibot-bugs-list, jayvdb, Malyacko _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
