jayvdb added a comment. The bug with regards to qualifiers vs references objects slipped in during https://phabricator.wikimedia.org/rPWBCcc62fbbac21f09e5e24b95df391ff25527456ee8 , which changed `qualifierFromJSON` so that `fromJSON` was called with `hash` provided.
Prior to that, since https://phabricator.wikimedia.org/rPWBCea33047d4c0f31263e125d5253162b083f86869e, `fromJSON` always set `isQualifier = True` even for primary claims which were neither qualifier or reference, but that is a different bug. I agree with the patch, which solves both bugs. Anyone calling `fromJSON` for a reference or a qualifier should have been using `referenceFromJSON` or `qualifierFromJSON`, which have existed for over two years, so there is no excuse for using `fromJSON` with a reference or a qualifier. TASK DETAIL https://phabricator.wikimedia.org/T113212 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: jayvdb, gerritbot, Aklapper, Lokal_Profil, pywikibot-bugs-list _______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
