jayvdb added a comment. In https://phabricator.wikimedia.org/T122047#1899384, @Mpaa wrote:
> In https://phabricator.wikimedia.org/T122047#1895830, @jayvdb wrote: > > > The problem is that many `pagegenerators` classes/generators explicitly > > instantiate a `pywikibot.Page`, rather than using an `api.PageGenerator`, > > including at least the following: > > > > - `NewpagesPageGenerator` ... > > > If you prefer upcasting and moving to ProofreadPage, that is not a problem. > To be noted anyhow that such generators are properly filterered even w/o > upcasting, as page.content_model is retrieved (via API) and checked. Yea, your code worked well. I would prefer upcasting, so that the proofreadpage functionality is kept within the proofread modules. We have code pending which can make proofreadpage and flow to be pywikibot extension packages, so I'd prefer to avoid adding proofreadpage and flow functionality, especially to the public interface of `Page`. TASK DETAIL https://phabricator.wikimedia.org/T122047 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Billinghurst, Aklapper, StudiesWorld, Mpaa, jayvdb, pywikibot-bugs-list, Krenair _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
