jayvdb triaged this task as "Low" priority. jayvdb added a comment.
As `pep257` has reached its end of life, and `tox.ini` has a pinned version of flake8-docstrings (see T119790: flake8-docstrings 0.2.2-0.2.4 are regressions <https://phabricator.wikimedia.org/T119790>), D403 will not be impacting pywikibot unless we explicitly switch to using a new version of `flake8-docstrings` or use `pydocstyle` directly. Only two problems remain using the new `pydocstyle` (see T119790: flake8-docstrings 0.2.2-0.2.4 are regressions <https://phabricator.wikimedia.org/T119790>): $ pydocstyle -s --select=D403 . Could not evaluate contents of __all__. That means pydocstyle cannot decide which definitions are public. Variable __all__ should be present at most once in each file, in form `__all__ = ('a_public_function', 'APublicClass', ...)`. More info on __all__: http://stackoverflow.com/q/44834/. ./pywikibot/login.py:388 in public method `consumer_token`: D403: First word of the first line should be properly capitalized ('Oauth', not 'OAuth') 388: def consumer_token(self): 389: """ 390: OAuth consumer key token and secret token. 391: 392: @rtype: tuple of two str 393: """ 394: return self._consumer_token ... ./pywikibot/login.py:397 in public method `access_token`: D403: First word of the first line should be properly capitalized ('Oauth', not 'OAuth') 397: def access_token(self): 398: """ 399: OAuth access key token and secret token. 400: 401: @rtype: tuple of two str 402: """ 403: return self._access_token ... A fix for those: diff --git a/pywikibot/login.py b/pywikibot/login.py index 36e29e8..8f57d96 100644 --- a/pywikibot/login.py +++ b/pywikibot/login.py @@ -387,7 +387,7 @@ class OauthLoginManager(LoginManager): @property def consumer_token(self): """ - OAuth consumer key token and secret token. + Return OAuth consumer key token and secret token. @rtype: tuple of two str """ @@ -396,7 +396,7 @@ class OauthLoginManager(LoginManager): @property def access_token(self): """ - OAuth access key token and secret token. + Return OAuth access key token and secret token. @rtype: tuple of two str """ TASK DETAIL https://phabricator.wikimedia.org/T121365 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: Negative24, Kat233hryn, Nemo_bis, gerritbot, Aklapper, StudiesWorld, jayvdb, pywikibot-bugs-list, Luke081515, Jay8g, Krenair _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
