DrTrigon added a comment.
In https://phabricator.wikimedia.org/T128946#2091074, @jayvdb wrote: > This will be much harder to package properly, as it is c++. True, this is part of the reason why I never did it myself. I appreciate your effort! > Now the important question -- which bits of this repo (if any) are needed for `catimages.py`. Have you ever had the bot running? That would make answering those questions easier as I did not run it for quite some time and things might have changed. > I dont see `posit` used by `catimages.py` I found 3 appearances: def _detect_Faces(self): def _util_get_Pose_POSIT(self, D3points, D2points): def _detect_Chessboard(self): In https://phabricator.wikimedia.org/T128946#2091075, @jayvdb wrote: > @AbdealiJK , if you think the same functionality can be achieved with another library, then we do not need to do this task ;-) This actually is THE crucial point, see next comment. And another reason why I asked whether you ran the bot once. In https://phabricator.wikimedia.org/T128946#2091079, @jayvdb wrote: > Lets expand this tasks scope a little, to include investigating `cv2` used by catimages. > > catimages.py 's first revision (https://phabricator.wikimedia.org/rPWBO4e302baecac70e28fc12de117928a3fdd00f6e44) used `cv2` described in the source as > > # TS: nonofficial cv2.so backport of the testing-version of > # python-opencv because of missing build-host, done by DaB > > > My guess is that this "testing-version of python-opencv" is now part of the main distributed library, and there is no need for a custom `cv2`. But it would be good to find out what "missing build-host" means. > > There are a bunch of Python packages that provide access to opencv : https://pypi.python.org/pypi?%3Aaction=search&term=opencv&submit=search > > It looks like none of them are the 'real' cv2 , according to http://answers.opencv.org/question/67725/opencv-in-pypi/ , which means catimages.py in core will need a custom ImportError message to inform the user how to install it. > > On Fedora, they recommend using yum/dnf to install the operating system package `opencv-python`. In ubuntu it appears to be called `python-opencv`. Debian doesnt appear to include it, but Wikimedia doesnt usually use Debian. As far as I remember we had 2 issues back then: 1. The ubuntu version used on the toolserver was older than the one on my local machine and thus contained other packages. DaB did this compile manually due to a missing build-host. 2. No matter how recent the ubuntu version used was, the opencv-python wrapper always had a lack of support for ALL cv2 functions, so I had to write diry/cheap and nasty wrappers myself. This gives the freedom to use THE WHOLE cv2 functionality as the c++ implementation is complete. Here is where e.g. the need for an automated build process came up; I had to make sure that the code got recompiled in case the toolserver would have been updated and thus included libraries changed. TASK DETAIL https://phabricator.wikimedia.org/T128946 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DrTrigon Cc: Multichill, DaBPunkt, pywikibot-bugs-list, jayvdb, DrTrigon, Aklapper, AbdealiJK, Anshoe _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
