jayvdb added a comment.
In https://phabricator.wikimedia.org/T128994#2092324, @Mpaa wrote: > I think it is already like that -> if not self._soup.find_all('a', attrs=attrs): Yes, I see that. Hmm. Then the test suite is regularly purging the page, and these attributes, etc are disappearing every time?? This test class currently uses `cached = True`, which I guess should be removed as it is doing a purge operation, so I expect that the caching will be returning the pre-purge cached page text. Strange. In https://phabricator.wikimedia.org/T128994#2092344, @Mpaa wrote: > Is it harmful just set write = True for those test classes? `write = True` means the tests dont run by default. Also, `write = True` currently checks that the site is a test wiki, not a real wiki, so these tests would need to only use `test2.wikipedia.org` . That is why I suggested we might add a special value for the `write` flag, which only permits the `purge` operation, which could be done on any wiki and not only test wikis. TASK DETAIL https://phabricator.wikimedia.org/T128994 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: jayvdb Cc: pywikibot-bugs-list, Mpaa, Aklapper, jayvdb _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
