Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T128987#2102904, @Lokal_Profil wrote: > What could account for travis behaving differently? The Travis CI job ran on Python 3.4, so the following condition applies: if sys.version_info[0] > 2: basestring = (str, ) A tuple is good for `isinstance()` but not for direct comparisons. In https://phabricator.wikimedia.org/T128987#2103136, @Lokal_Profil wrote: > There is something subtle going on here: > > >>> Claim.types.get(claim.type) > <type 'basestring'> > >>> basestring > <type 'basestring'> > >>> isinstance(Claim.types.get(claim.type), basestring) > False > Nothing strange, you're basically asking for `isinstance(basestring, basestring)` which is of course `False`. TASK DETAIL https://phabricator.wikimedia.org/T128987 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lokal_Profil, Ricordisamoa Cc: Ricordisamoa, Xqt, Lokal_Profil, Aklapper, jayvdb, pywikibot-bugs-list _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
