darthbhyrava added a comment.
In https://phabricator.wikimedia.org/T129193#2120073, @Mpaa wrote: > I think that p['ns'] should not be an issue. > > Actually I do not understand why the docstring in RecentChangesPageGenerator says: > > @param changetype: only iterate changes of this type ("edit" for > edits to existing pages, "new" for new pages, "log" for log > entries) > > > while, then, log is excluded. > > Wrong docstring or clause? We already have `-logevents` to deal with recent log entries, that is probably why it is excluded. I'll look into it, and confirm. About the `p['ns']` - should I include it or exclude it when merging with imageuncat's code? And the issue of `gen.request ['rcprop']` remains. What can be done about it if we merge the code without the `from_imageuncat` param? @jayvdb? TASK DETAIL https://phabricator.wikimedia.org/T129193 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: darthbhyrava Cc: Mpaa, gerritbot, darthbhyrava, Aklapper, Avicennasis, pywikibot-bugs-list, jayvdb, Lewizho99 _______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
