jayvdb added a comment.

  I dont understand your intention with these tasks.
  
  Do you mean that `repr(page).decode('ascii')` should not  cause 
`UnicodeDecodeError` ?
  
  If so, I would like a more detailed explanation of why it should not cause 
`UnicodeDecodeError`.
  
  This certainly can be explained better in the test, but despite many many 
efforts, this is the best `repr` that we can build that does the 'right' thing 
in as many cases as possible.
  
  As the comment in this test says "Bug 
https://phabricator.wikimedia.org/T95809, the repr in Python 2 should be 
decodable as ASCII"
  
  The output of `repr` **should** be ASCII on Python 2, according to the spec , 
however the Python 2 console accepts bytes in the console encoding, so we give 
it bytes in the console encoding which means unicode characters are displayed 
correctly.  If `repr` must return ASCII, then non-ASCII must be downgraded to 
ASCII somehow, which isnt pretty.
  
  IMO this is exactly what `expectedFailure` is designed for, and I've 
presented my opinion supporting their use at 
https://phabricator.wikimedia.org/T129368#2153128 , where we can continue that 
debate.

TASK DETAIL
  https://phabricator.wikimedia.org/T130919

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jayvdb
Cc: jayvdb, Aklapper, Xqt, pywikibot-bugs-list



_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to