jayvdb added a comment.
I cant find any more indent problems ;-)
There are lots of trailing whitespace problems, simply because there is
attempt to indicate where the end of line is. I think that problem needs to be
a separate design task. Not easy. I think we need to use a background color
to solve that, and/or an illegal wikitext character for the end of line, if one
exists.
However I have found one more strange coloring with the proposed algorithm.
With the following input, the old lines are completely red, when only minor
changes were made.
{default}Foo bar Pywikipediabot foo bar
Pywikipediabot foo
$ python pwb.py replace -family:test -lang:test
-page:"User:John_Vandenberg/diff_test" -regex " +" " "
The summary message for the command line replacements will be something
like: Bot: Automated text replacement (- + + )
Press Enter to use this automatic message, or enter a description of the
changes your bot will make:
Retrieving 1 pages from test:test.
>>> User:John Vandenberg/diff test <<<
@@ -7,2 +7,2 @@
- {default}Foo bar Pywikipediabot foo bar
+ {default}Foo bar Pywikipediabot foo bar
- Pywikipediabot foo
+ Pywikipediabot foo
The proposed algorithm doesnt highlight red other lines with whitespace only
changes, so I think this scenario should also not highlight the entire line
red. i.e. I think we need to leave whitespace only changes to a different task.
However if this last problem is not easy to solve, maybe we merge and create
separate tasks for the remaining edge cases. And create tests for the merged
solution, so we dont regress with future improvements.
TASK DETAIL
https://phabricator.wikimedia.org/T130572
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: jayvdb
Cc: gerritbot, Mpaa, Aklapper, jayvdb, pywikibot-bugs-list, Lewizho99, Mdupont,
Maathavan
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
