jayvdb added a comment.

  An alternative solution is to del the `_isredir` of every page emitted by 
`APISite.broken_redirects`, which will cause the page info to be loaded on 
demand with the correct `redirect` status.  That is IMO the 'correct' solution, 
because we know the special page emit incorrect data for that property.
  
  The provided patch only works around the problem within `getredirtarget` -- 
if these Page objects are used in other ways, not involving `getredirtarget`, 
other bugs will occur.
  
  Anyway, the MediaWiki bug should be raised 
https://phabricator.wikimedia.org/tag/upstream/ , which will help us understand 
the bug better.  Maybe other properties in the page info are also wrong??  If 
other attributes are wrong, IMO we should clearly state that Pages emitted from 
`broken_redirects` is very likely to be incorrect, and it is the callers 
responsibility to recheck the data.

TASK DETAIL
  https://phabricator.wikimedia.org/T130911

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, jayvdb
Cc: jayvdb, gerritbot, Aklapper, Xqt, pywikibot-bugs-list, Lewizho99, Mdupont, 
Maathavan



_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to