| valhallasw added a comment. |
I think your patch makes a lot of sense. The current situation already is a bit of a mess (because everything is split through three classes without a clear separation of concerns).
On the one hand having self.login_name feels like storing that information in the wrong place, but at the same time, we already do that with self.password. Fixing that might be better for a larger rebuild of the whole LoginManager class.
TASK DETAIL
EMAIL PREFERENCES
To: valhallasw
Cc: gerritbot, Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, Mdupont, JJMC89
Cc: gerritbot, Lokal_Profil, jayvdb, Liuxinyu970226, Alkamid, Aklapper, StudiesWorld, valhallasw, pywikibot-bugs-list, Mdupont, JJMC89
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
