Lokal_Profil added a comment.

I usually recommend keeping lines below 80 characters, but only for those lines that are newly added. Older lines are usually kept unchanged which I assume helps when using git blame or searching the git log for specific change.

But personally I feel much more comfortable with the 80 characters line limit and would vote to merge changes like https://gerrit.wikimedia.org/r/#/c/287412/ .

I'm happy to merge as is. Consistently applying the 80 char limit trumps the minor aesthetic loss in this particular case.
One work-around would be to go for something like:

self.pageAgeBefore = self.repo.getcurrenttime() - \
                     timedelta(days=self.pageAge)

which is slightly clearer but has it's own aesthetic losses.


TASK DETAIL
https://phabricator.wikimedia.org/T152996

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magul, Lokal_Profil
Cc: Lokal_Profil, Mpaa, Dalba, Xqt, gerritbot, Magul, Aklapper, JAnD, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to