| Lokal_Profil added a comment. |
In T143594#2932697, @Dalba wrote:You mean having unit take either an entity url or a pywikibot.ItemPage? Rather than splitting these over two parameters?
Yes.
and keeps it more in line with how Coordinate is handled.
Maybe the entity parameter of Coordinate should also be changed to accept both a URL or an ItemPage?
I haven't checked if combining the two is possible but can take a look if you feel it is a blocker.
I don't know if "blocker" is the right term for it, I wouldn't even -1 the current patch because of this, but I surely appreciate if you could take some time to see if what I suggested can implemented in a neat way or not and maybe upload a separate patch for it.
I'll take a closer look and see if it can be implemented in that way. My only worry (without having looked at it closer yet) is the fact that "no unit" is passed around as the literal "1".
Cc: Dalba, Xqt, Beta16, Multichill, ArthurPSmith, gerritbot, Ladsgroup, Aklapper, Lokal_Profil, pywikibot-bugs-list, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Ricordisamoa, Wesalius, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list pywikibot-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
