[Pywikipedia-bugs] [Maniphest] [Commented On] T155740: FilePage.get_file_history() does not load imageinfo

Thu, 19 Jan 2017 11:59:06 -0800

Mpaa added a comment.

ugh ... 2 years back, I wish I could remeber :-)
I also went through the review process but did not find a clue.

I guess because apy.update_page() expects it for a FilePage:

if 'imageinfo' in pagedict:
        assert(isinstance(page, pywikibot.FilePage))
        for file_rev in pagedict['imageinfo']:
            file_revision = pywikibot.page.FileInfo(file_rev)
            page._file_revisions[file_revision.timestamp] = file_revision


I agree it is wrong. Maybe the best is to replace:



if not hasattr(self, '_file_revisions'):



with



if not len(self._file_revisions):



as for the other methods (probably I forgot to update get_file_history() at some point of the development of this patch).

TASK DETAIL
https://phabricator.wikimedia.org/T155740

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mpaa
Cc: Aklapper, pywikibot-bugs-list, Mpaa, zhuyifei1999, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to