[Pywikipedia-bugs] [Maniphest] [Updated] T85483: `APISite.is_data_repository` does not work if `self` is an `APISite`

[matej_suchanek]

matej_suchanek added a project: TestMe. matej_suchanek added a comment. Herald added a subscriber: TerraCodes.

I think the method now works as expected.

>>> import pywikibot
>>> site = pywikibot.Site('en', 'wikipedia')
>>> site.is_data_repository()
False
>>> repo = site.data_repository()
>>> repo
DataSite("wikidata", "wikidata")
>>> repo.is_data_repository()
True
>>> pywikibot.Site('wikidata', 'wikidata')
DataSite("wikidata", "wikidata")
>>> pywikibot.Site('en', 'wiktionary').is_data_repository()
False

The only thing we could do better is to override this method in DataSite():

def is_data_repository(self):
  return True

since Site.data_repository() always returns DataSite().

Note that this task is referenced from two places in code, so some cleanup would be useful.

TASK DETAIL

https://phabricator.wikimedia.org/T85483

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: matej_suchanek, TerraCodes, jayvdb, Ricordisamoa, Aklapper, pywikibot-bugs-list, Pietrodn, Lydia_Pintscher, XZise, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, Luke081515, Wesalius, Dalba, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs