Lokal_Profil added a comment.

@Dalba @Xqt @Magul: Should this patch be abandoned with the merging of https://gerrit.wikimedia.org/r/337348?

Apparently that patch is pursuing another goal: "Make pageids validation's error more descriptive". But personally, I don't find think it's worth the added complexity and it's not common for users to pass something other than valid pageids to load_pages_from_pageids. In the rare case that they do I find the ValueError: invalid literal for int() with base 10: '' descriptive enough.

A quick fix might be to wrap the gen = call in a try`


TASK DETAIL
https://phabricator.wikimedia.org/T153592

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magul, Lokal_Profil
Cc: Lokal_Profil, Dalba, Xqt, gerritbot, pywikibot-bugs-list, Aklapper, jayvdb, Magul, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Sn1per, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to