[Pywikipedia-bugs] [Maniphest] [Created] T168806: Don't show warning when password file contain comments or imports lines

[Framawiki]

Framawiki created this task. Framawiki added a project: Pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

Current code

pywikibot/login.py

password_f = codecs.open(password_file, encoding='utf-8')
for line_nr, line in enumerate(password_f):
    if not line.strip():
        continue
    try:
        entry = eval(line)
    except SyntaxError:
        entry = None
    if type(entry) is not tuple:
        warn('Invalid tuple in line {0}'.format(line_nr),
             _PasswordFileWarning)
        continue
    if not 2 <= len(entry) <= 4:
        warn('The length of tuple in line {0} should be 2 to 4 ({1} '
             'given)'.format(line_nr, entry), _PasswordFileWarning)
        continue

if type(entry) is not tuple is not good

It'll be particularly visible when T143905: Add support for BotPasswords in generate_user_files.py will be merged

TASK DETAIL

https://phabricator.wikimedia.org/T168806

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Framawiki
Cc: Aklapper, pywikibot-bugs-list, Framawiki, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs