| Dalba added a comment. |
In T169649#3405836, @Xqt wrote:After this patch there are few remaining failures but I don't see the point e.g. of
https://travis-ci.org/magul/pywikibot-core/jobs/250057193> self.assertLessEqual(pt_ns_10, pt_all) E AssertionError: [Page('Template:•'), Page('Template:HomePages'), Page('Template:Edi'), Page('Template:Ill')] not less than or equal to [Page('Wikipedia:What we do on this wiki'), Page('Template:Ill'), Page('Template:HomePages'), Page('Wikipedia:Bureaucrats'), Page('Wikipedia:Administrators'), Page('Template:•'), Page('Wikipedia:What Test Wiki is not'), Page('Template:Edi')] tests/site_tests.py:564: AssertionErrorAll items of the first set are in the second.
I'm in favour of removing it. It's making things unnecessary complicated. The current patch could fail if the random part is part of a the initial title segment. It is also vulnerable to race conditions like the one in T92856#3310672.
It might be enough to just check that pagetemplates are all from template namespace.
TASK DETAIL
EMAIL PREFERENCES
To: Xqt, Dalba
Cc: Dalba, Mpaa, gerritbot, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
Cc: Dalba, Mpaa, gerritbot, valhallasw, Aklapper, Xqt, pywikibot-bugs-list, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
