| Dvorapa added a comment. |
@Framawiki Personally I don't think this should be disabled. Better approximate count than nothing. And this bug is noticeable only when a really low count of pages was edited. For hundreds of pages or more one extra or one missing is not a big deal.
@matej_suchanek @Mpaa Apart from what has been already mentioned (mainly T151727), there are some other possibilities, how to deal with this issue. First of all maybe something like this: 0 pages changed, 1 pages still in progress?? I would prefer this solution and it seems to me as #easy one. Another option could be to pass n pages changed summary on the second thread (and return that output after all jobs of second thread are done after callback is out somehow, but I don't really know how this could work here). Or just make first thread wait for async callback, but this approach is not really async at all.
In T147178#3567967, @matej_suchanek wrote:The funniest fact at the end: this script has sync/async saving swapped, compared to other standard bots. In other words, with -always ([a]) it saves synchronously, in manual mode ([y]) asynchronously.
@matej_suchanek Maybe the funniest, but completely logical. When reviewing one page after another using y or n options, user doesn't want to wait for script to process and save a page. User just wants to see diff and make a decision, see another diff and make another decision, process/save stuff should run in the background (second thread) and not waste user's time. In always mode user usually doesn't care, when script saves the page, it can be synced or asynced, whatever (but better synced in order to have a clean and readable terminal/log output.
Cc: gerritbot, matej_suchanek, jeblad, Framawiki, Danmichaelo, Zoranzoki21, Dvorapa, Danny_B, Zppix, JAnD, binbot, Aklapper, Mpaa, Xqt, pywikibot-bugs-list, Jrbranaa, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
