eflyjason added a comment.

One implementation is to perform file locking on whichever is being downloaded on, and exit with an error if the will-be-written file is locked. Another is to avoid same-filenames entirely.

Based on https://stackoverflow.com/q/489861/2603230, it seems that locking file is really complicated especially when this script has to be cross-platform. I guess downloading the file with name e.g. '<filename>-2017-12-25-09-27-23.part' would be better if we want to avoid same-filenames entirely.


TASK DETAIL
https://phabricator.wikimedia.org/T183675

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: eflyjason
Cc: Framawiki, Aklapper, Xqt, jayvdb, siebrand, Zoranzoki21, eflyjason, pywikibot-bugs-list, zhuyifei1999, Bright1055, Toppole69, Mine0901, Jayprakash12345, Magul, Tbscho, MayS, Beeyan, Mdupont, JJMC89, MtDu, D3r1ck01, Avicennasis, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to