zhuyifei1999 added a comment.

(Sorry I wasn't reading the discussion here)
Copying my comment on the patch:

From a dump consumer perspective, it would be great if the filename is as predictable as possible. With the current implementation the consumer will have to check whether the file downloaded today, yesterday, the day before yesterday, etc. until it finds one that is successful.

Honestly T183667#3864150 will be IMO a better implementation, but yes it will risk old dumps wasting all the storage. Perhaps we could add a functionality to this script that remove old dumps, only when a flag is specified / not specified and/or ask for permission before remove (except when -always is specified), and only when the revision is set to latest.


TASK DETAIL
https://phabricator.wikimedia.org/T183667

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: rafidaslam, zhuyifei1999
Cc: gerritbot, rafidaslam, divadsn, eflyjason, pywikibot-bugs-list, Aklapper, Xqt, zhuyifei1999, jayvdb, siebrand, Zoranzoki21, Framawiki, Cpaulf30, Bright1055, Baloch007, Darkminds3113, Toppole69, Lordiis, Adik2382, Mine0901, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Beeyan, Lewizho99, Mdupont, JJMC89, Maathavan, MtDu, D3r1ck01, Avicennasis, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to