jayvdb added a comment.

This was done at my request during code review because this script wasnt being tested with tests/script_tests.py which it should be.

This script is not a maintenance script. maintenance scripts are not tested, because they are used for scripts used to maintain pywikibot only.

scripts has a wide variety of contents, including tools which dont do anything, like version & shell, and scripts which only work on wikimedia sites, like all of the Wikidata specific scripts. Those are not reasons to put it under a different directory.
If anyone is insisting that it must be under maintenance, then they must improve the test framework to test maintenance scripts also.
Otherwise I turn off all pywikibot GCI tasks related to this script because they are bypassing the test suite as it exists.


TASK DETAIL
https://phabricator.wikimedia.org/T184033

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: rafidaslam, jayvdb
Cc: jayvdb, zhuyifei1999, gerritbot, Aklapper, Framawiki, rafidaslam, pywikibot-bugs-list, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to