| divadsn added a subscriber: jayvdb. divadsn added a comment. |
In T185317#3913844, @Dalba wrote:In T185317#3913727, @divadsn wrote:@Dalba ok, that's a point, but now why the revert?
That patch could be fixed with a follow-up, which would be simply adding a |Invalid ISBN found to the regex, why not instead?
IMO, https://gerrit.wikimedia.org/r/#/c/399348/ was more deserved to be merged. It was submitted before your patch and it did not have this issue.
But it had other issue and the author wasn't doing anything for a month since that day, that's why I took it up and made mine when working on the task with @jayvdb as mentor.
To the discussion with assertRaises, IMO assertRaisesRegex is fragile only when certain things aren't met like they should be when testing, like requirements or Python versions. If Pywikibot would be required to run on for example newer version of Python 3 with requirements only, it surely would work fine. But that's rather a discussion about supporting a range of versions and requirements.
Cc: jayvdb, Albert221, divadsn, gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
