[Pywikipedia-bugs] [Maniphest] [Edited] T191146: user_tests.TestUserClass fails for user.is_thankable

[Dalba]

Dalba updated the task description. (Show Details)

CHANGES TO TASK DESCRIPTION

See https://travis-ci.org/wikimedia/pywikibot/builds/360619104
```lang=python
=================================== FAILURES ===================================
________________________ TestUserClass.test_female_user ________________________
self = <tests.user_tests.TestUserClass testMethod=test_female_user>
def test_female_user(self):
"""Test female user."""
user = User(self.site, 'Alraunenstern')
self.assertTrue(user.isRegistered())
self.assertFalse(user.isAnonymous())
self.assertGreater(user.editCount(), 0)
self.assertEqual(user.gender(), 'female')
self.assertIn('userid', user.getprops())
> self.assertTrue(user.is_thankable)
E AssertionError: False is not true
tests/user_tests.py:82: AssertionError
_______________________ TestUserClass.test_invalid_user ________________________
self = <tests.user_tests.TestUserClass testMethod=test_invalid_user>
def test_invalid_user(self):
"""Test invalid user."""
user = User(self.site, 'Invalid char\x9f in Name')
with suppress_warnings('pywikibot.page.User.name', DeprecationWarning):
self.assertEqual(user.name(), user.username)
self.assertEqual(user.title(withNamespace=False), user.username)
self.assertFalse(user.isRegistered())
self.assertFalse(user.isAnonymous())
self.assertIsNone(user.registration())
self.assertFalse(user.isEmailable())
self.assertEqual(user.gender(), 'unknown')
self.assertIn('invalid', user.getprops())
> self.assertFalse(user.is_thankable)
E AssertionError: True is not false
tests/user_tests.py:124: AssertionError
______________________ TestUserClass.test_registered_user ______________________
self = <tests.user_tests.TestUserClass testMethod=test_registered_user>
def test_registered_user(self):
"""Test registered user."""
user = User(self.site, 'Xqt')
with suppress_warnings('pywikibot.page.User.name', DeprecationWarning):
self.assertEqual(user.name(), user.username)
self.assertEqual(user.title(withNamespace=False), user.username)
self.assertTrue(user.isRegistered())
self.assertFalse(user.isAnonymous())
self.assertIsInstance(user.registration(), pywikibot.Timestamp)
self.assertGreater(user.editCount(), 0)
self.assertFalse(user.isBlocked())
self.assertTrue(user.isEmailable())
self.assertEqual(user.gender(), 'unknown')
self.assertIn('userid', user.getprops())
self.assertEqual(user.getprops()['userid'], 287832)
self.assertEqual(user.pageid, 6927779)
self.assertEqual(user.getUserPage(),
pywikibot.Page(self.site, 'Benutzer:Xqt'))
self.assertEqual(user.getUserPage(subpage='pwb'),
pywikibot.Page(self.site, 'Benutzer:Xqt/pwb'))
self.assertEqual(user.getUserTalkPage(),
pywikibot.Page(self.site, 'Benutzer Diskussion:Xqt'))
self.assertEqual(user.getUserTalkPage(subpage='pwb'),
pywikibot.Page(self.site,
'Benutzer Diskussion:Xqt/pwb'))
> self.assertTrue(user.is_thankable)
E AssertionError: False is not true
tests/user_tests.py:51: AssertionError
_____________ TestUserClass.test_registered_user_without_timestamp _____________
self = <tests.user_tests.TestUserClass testMethod=test_registered_user_without_timestamp>
def test_registered_user_without_timestamp(self):
"""Test registered user when registration timestamp is None."""
user = User(self.site, 'Ulfb')
self.assertTrue(user.isRegistered())
self.assertFalse(user.isAnonymous())
self.assertIsNone(user.registration())
self.assertIsNone(user.getprops()['registration'])
self.assertGreater(user.editCount(), 0)
self.assertEqual(user.gender(), 'male')
self.assertIn('userid', user.getprops())
> self.assertTrue(user.is_thankable)
E AssertionError: False is not true
tests/user_tests.py:72: AssertionError
_____________________ TestUserClass.test_unregistered_user _____________________
self = <tests.user_tests.TestUserClass testMethod=test_unregistered_user>
def test_unregistered_user(self):
"""Test unregistered user."""
user = User(self.site, 'This user name is not registered yet')
with suppress_warnings('pywikibot.page.User.name', DeprecationWarning):
self.assertEqual(user.name(), user.username)
self.assertEqual(user.title(withNamespace=False), user.username)
self.assertFalse(user.isRegistered())
self.assertFalse(user.isAnonymous())
self.assertIsNone(user.registration())
self.assertFalse(user.isEmailable())
self.assertEqual(user.gender(), 'unknown')
self.assertIn('missing', user.getprops())
> self.assertFalse(user.is_thankable)
E AssertionError: True is not false
tests/user_tests.py:110: AssertionError
```

TASK DETAIL

https://phabricator.wikimedia.org/T191146

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt, Dalba
Cc: gerritbot, Aklapper, Xqt, pywikibot-bugs-list, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, rafidaslam, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs