[Pywikipedia-bugs] [Maniphest] [Created] T192540: api is able to run into an infinite loop

[Xqt]

Xqt created this task. Xqt added a project: Pywikibot-core. Herald added subscribers: pywikibot-bugs-list, Aklapper.

TASK DESCRIPTION

Currently we haven't seen this problem but api.Requests.init is potential dangerous. At the end of the initializer method self.site.Version is called under some conditions. This could lead to an infinite loop. Try the following:

pwb.py Shell
>>> import pywikibot as py
>>> s = py.Site()
>>> s.version()
1.31.0-wmf.29
exit()

now replace self.write in line 1456 with True:

pwb.py Shell
>>> import pywikibot as py
>>> s = py.Site()
>>> s.version()
...
<very huge traceback>
...
RecursionError: maximum recursion depth exceeded

TASK DETAIL

https://phabricator.wikimedia.org/T192540

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Xqt
Cc: Aklapper, pywikibot-bugs-list, Xqt, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, jayvdb, Dalba, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs