Lokal_Profil added a comment.

+1 for this idea. It will also make T76615: Claim equality operator easier to deal with.

One note though is that the the suggestion above does not match Wikibase steucture as described in https://phabricator.wikimedia.org/T76615#3464800. Importantly pywikibot.Claim here is a mixture of Claim (value +Qualifiers) and Statement (Claim+References).

If we are breaking things this would be a great time to drop the missleading target_equals (or rename it to clarify its not a true equals).
Might also be worth considering if self.qualifiers should be simple dict (since Wikibase does not say the order has significance).


TASK DETAIL
https://phabricator.wikimedia.org/T186200

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lokal_Profil
Cc: Lokal_Profil, Aklapper, matej_suchanek, pywikibot-bugs-list, Magul, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Dvorapa, Avicennasis, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to