| Mpaa added a comment. |
In T198999#4405235, @Dvorapa wrote:Also it fails on AppVeyor and Travis
I could not find a fail related to this.
It should fail like this:
F
======================================================================
FAIL: test_applicable_quality_level (tests.proofreadpage_tests.TestPageQuality)
Test Page.quality_level when applicable.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/squiddy/python/core/tests/proofreadpage_tests.py", line 315, in test_applicable_quality_level
self.assertEqual(page.quality_level, 0)
AssertionError: '0' != 0due to 'quality': '0' here:
{'pageid': 435605, 'ns': 104, 'title': 'Page:Popular Science Monthly Volume 49.djvu/1', 'contentmodel': 'proofread-page', 'pagelanguage': 'en', 'pagelanguagehtmlcode': 'en', 'pagelanguagedir': 'ltr', 'touched': '2018-07-07T16:41:59Z', 'lastrevid': 7555835, 'length': 13, 'protection': [], 'restrictiontypes': ['edit', 'move'], 'proofread': {'quality': '0', 'quality_text': 'Without text'}}For convenience, internally uses ints for quality value, so it should be converted to int as in the patch.
TASK DETAIL
EMAIL PREFERENCES
To: Mpaa
Cc: Dvorapa, gerritbot, Aklapper, pywikibot-bugs-list, Mpaa, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
Cc: Dvorapa, gerritbot, Aklapper, pywikibot-bugs-list, Mpaa, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Magul, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
