| matej_suchanek added a comment. |
Oh, I realized that my bot couldn't crash because of the loaded content because the preloaded items are instances of different objects than the generator yields... maybe. But still, if I preloaded the objects yielded by the generator, they are burried in the collection and nothing can flush their attributes, so this drains the memory space faster.
Another problem I can see is that filter_unique (inside GenFact it is self._filter_unique) is used twice: it's provided to RecentChangesPageGenerator (line 821) and also used for dupfiltergen = self._filter_unique(gensList) (line 532). This means there are two same independent sets, one of which is redundant.
TASK DETAIL
EMAIL PREFERENCES
To: matej_suchanek
Cc: Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
Cc: Xqt, Aklapper, matej_suchanek, pywikibot-bugs-list, Magul, Tbscho, MayS, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
