Dalba raised the priority of this task from "Low" to "High".
Dalba moved this task from Waiting on other changes to Backlog on the Pywikibot-core board.
Dalba added a comment.

I ran some test builds and it turned out that if only the specific failing tests are run, then they pass OK, but when running the whole test suite they fail. When the tests are failing the extension name is Wikibase Client.

I printed the value of siteinfo['extensions'] right before the failing part and saw this entry for wikibase client:

[00:04:09]  {u'author': u'The Wikidata team',
[00:04:09]   u'credits': u'/wiki/Special:Version/Credits/Wikibase_Client',
[00:04:09]   u'descriptionmsg': u'wikibase-client-desc',
[00:04:09]   u'license': u'/wiki/Special:Version/License/Wikibase_Client',
[00:04:09]   u'license-name': u'GPL-2.0+',
[00:04:09]   u'name': u'Wikibase Client',
[00:04:09]   u'type': u'wikibase',
[00:04:09]   u'url': u'https://www.mediawiki.org/wiki/Extension:Wikibase_Client',
[00:04:09]   u'vcs-date': u'2018-01-03T16:59:50Z',
[00:04:09]   u'vcs-system': u'git',
[00:04:09]   u'vcs-url': u'https://phabricator.wikimedia.org/r/revision/mediawiki/extensions/Wikibase;61f3d290375663c6dcd4aee6ee596e888bd25a04',
[00:04:09]   u'vcs-version': u'61f3d290375663c6dcd4aee6ee596e888bd25a04'},

Notice the 2018-01-03T16:59:50Z date tag. It's very old. Where is it comming from?: The .yml files that store the responses for vcrpy (T184081).

This is what's happening: Sometime during the build, a vcrpy test is ran, that causes the Siteinfo cache to be loaded from the frozen response in the yml files. This old response will be stored in Siteinfo's cache. Other tests will start using the old response...

I'm thinking that it would be much easier to just remove vcrpy tests and decline T184081. I've had several issues with it so far and I don't believe it's worth the trouble.


TASK DETAIL
https://phabricator.wikimedia.org/T198454

WORKBOARD
https://phabricator.wikimedia.org/project/board/87/

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dalba
Cc: Dvorapa, gerritbot, Aklapper, pywikibot-bugs-list, Dalba, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to