[Pywikipedia-bugs] [Maniphest] [Commented On] T186200: Rewrite Wikibase data model implementation

Wed, 05 Sep 2018 05:40:14 -0700

Pintoch added a comment.

I think reworking this implementation would be very welcome because at the moment it is not pretty, to say it politely.
But I am not convinced by the alternative either. Why would Reference inherit from BaseClaim? A reference is not a claim. What would the getSnakType method mean when called on a Reference?

Maybe you could have a look at the Java library Wikidata-Toolkit: the data model is implemented very well there. No nonsensical inheritance relationships, clean and precise interfaces.

https://github.com/Wikidata/Wikidata-Toolkit/tree/master/wdtk-datamodel/src/main/java/org/wikidata/wdtk/datamodel/interfaces


TASK DETAIL
https://phabricator.wikimedia.org/T186200

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pintoch
Cc: Pintoch, Dvorapa, Lokal_Profil, Aklapper, matej_suchanek, pywikibot-bugs-list, Tbscho, MayS, Framawiki, Mdupont, JJMC89, Avicennasis, mys_721tx, jayvdb, Ricordisamoa, Dalba, Masti, Alchimista, Rxy
_______________________________________________
pywikibot-bugs mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs

Reply via email to