[Pywikipedia-bugs] [Maniphest] [Commented On] T191632: l10n_tests should run only once for every committed patch

[Dvorapa]

Dvorapa added a comment.

The whole haqndling with disabled_test_modules is a bit weird:

Line 151

	disabled_test_modules = [
	    'tests',  # tests of the tests package
	    'l10n',
	]

OK, these will be disabled

Line 155
if not i18n.messages_available():
	    disabled_test_modules.append('l10n')

Isn't this already in the list?

Line 187
if 'PYWIKIBOT_TEST_MODULES' in os.environ:
	    disabled_test_modules = set(test_modules) - set(_enabled_test_modules)

Now we overwrite it even before we use it?

TASK DETAIL

https://phabricator.wikimedia.org/T191632

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Dvorapa
Cc: gerritbot, Dvorapa, Aklapper, Dalba, Xqt, pywikibot-bugs-list, CucyNoiD, NebulousIris, Wenyi, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, Tbscho, MayS, Lewizho99, Mdupont, JJMC89, Maathavan, Avicennasis, mys_721tx, jayvdb, Masti, Alchimista, Rxy

_______________________________________________
pywikibot-bugs mailing list
pywikibot-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs