Jacek.duszenko added a subscriber: Xqt. Jacek.duszenko added a comment.
Hello again, I've uploaded the change, then I improved the code according to @Xqt review. Can you please look at my second patch commit message? It isn't written anywhere how should it look. The problem is that this second patch message has messages of both my commits (one of them was squashed into another). Should this message look as is now? Or maybe it is to contain only one message. If yes, then which commit message? Also I'am wondering if the first Jenkins build fail was because of flake8 warnings or something else screwed up? Also @Xqt I think I added the second patch before you finished your remarks concerning first patch, could you please look at it one again? Can I write you a pm with questions relevant to the code? Or at least please point me to the place where I could write comments that would concern the code. Thanks TASK DETAIL https://phabricator.wikimedia.org/T216455 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jacek.duszenko Cc: Xqt, Dvorapa, Aklapper, Zoranzoki21, pywikibot-bugs-list, Wenyi, Kieubinhtb, Asad_Ali_Palijo, Lahi, Soteriaspace, RazeSoldier, JakeTheDeveloper, Tbscho, MayS, Ivanhercaz, Mdupont, JJMC89, TerraCodes, Avicennasis, MuhammadShuaib, SimmeD, mys_721tx, jayvdb, Dalba, Masti, Alchimista, Rxy
_______________________________________________ pywikibot-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/pywikibot-bugs
